Support a config to make read index read failfast. #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
reviewed
Dec 23, 2021
jraft-core/src/main/java/com/alipay/sofa/jraft/option/RaftOptions.java
Outdated
Show resolved
Hide resolved
killme2008
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Read index read need compare current node's apply index with leader's commit index. Only current node's apply index catch up leader's commit index, then call back success to read index closure. Therefore, there is a waiting time. The default wait timeout is 2s. It means that the waiting time over 2s, then call back failure to read index closure. If current node occur problem, it's apply index maybe behind leader's commit index. In read index timeout, it can't catch up, the timeout is waste. Here supply a config to fix it. If the gap greater than readIndexToleranceThreshold, fail fast to call back failure read index closure.