[visual] Adds features to LineAxis and DrawTools #5258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes usage of thickness - new feature: infinite lines - new feature: vanishing infinite line - fixes typo
bakpaul
approved these changes
Feb 4, 2025
bakpaul
added
the
pr: status to review
|
|
||
| std::vector<type::Vec2i> indices = {type::Vec2i(0,1)}; | ||
|
|
||
| auto box = getContext()->f_bbox.getValue().maxBBox() - getContext()->f_bbox.getValue().minBBox(); |
There was a problem hiding this comment.
I would factorize the getContext()->f_box.getValue() /
|
Nice @EulalieCoevoet 👍 |
|
[ci-build] |
hugtalbot
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
LineAxis: fixes the usage of the datathickness(it wasn't used).LineAxis: adds the option to draw the lines as infinite lines (new feature)DrawTools: adds a method to change the thickness of the infinite lineDrawTools: adds an option to make the infinite line visually gradually vanishingResults:
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if