Refactor panic source location tests #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soenkehahn
commented
May 4, 2022
tests/panic_source_locations.rs
Outdated
| @@ -0,0 +1,39 @@ | |||
| #[allow(unused_imports)] | |||
There was a problem hiding this comment.
These unused_imports attributes (and the dead_code attribute below) are to silence warnings for rustc-versions < 1.46. Is there a better way to do this?
There was a problem hiding this comment.
Can you make the imports conditional?
#[rustversion::since(1.46)]
use foo;
soenkehahn
commented
May 4, 2022
soenkehahn
commented
May 4, 2022
| assert_eq!( | ||
| Some("tests/panic_source_locations.rs:19:16".to_string()), | ||
| panic_location | ||
| ); |
There was a problem hiding this comment.
These two assertions are in the same test to make sure they're not executed in parallel. get_panic_location is not thread-safe, since it modifies the global panic handler. There's other ways to solve this, not sure they're better though.
There was a problem hiding this comment.
Can't this also race with other tests, if those tests panic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the
test_executables_panicexecutable, while re-implementing the same tests in a different way. I think this is better since the executable is not meant for users of the library and as such ideally shouldn't show up in theCargo.tomlfile.(I also would like to get rid of
test_executables_helperat some point.)