Don't read stderr into memory when not captured #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casey
reviewed
Aug 10, 2021
src/collected_output.rs
Outdated
| @@ -54,15 +54,21 @@ impl Waiter { | |||
| }); | |||
| let mut context_clone = context.clone(); | |||
| let capture_stderr = config.capture_stderr; | |||
| let stderr_join_handle = thread::spawn(move || -> io::Result<Vec<u8>> { | |||
| let mut collected_stderr = Vec::new(); | |||
| let stderr_join_handle = thread::spawn(move || -> io::Result<Option<Vec<u8>>> { | |||
There was a problem hiding this comment.
I wonder if this could be DRYed up. The code here seems nontrivial, so merging the stdout and stderr capture would be nice.
There was a problem hiding this comment.
What do you think of 4015e1c?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #143. Fixes #26.