Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for updating image policy #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sushanthakumar
Copy link
Collaborator

Updating image policy

What type of PR is this?

/kind enhancement

What this PR does / why we need it:
This PR improves default config for image policy

Which issue(s) this PR fixes:
This PR fixes
#485

Fixes #

Test Report Added?:

/kind TESTED

Test Report:

  1. Tested scenario1

Special notes for your reviewer:

Updating image policy
Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention why the image policy needs to be changed.

@sushanthakumar
Copy link
Collaborator Author

ase mention why the image policy needs to be changed.

Better to have default as Never

@anvithks
Copy link
Member

ase mention why the image policy needs to be changed.

Better to have default as Never

Ok. thanks.

Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
#SODACODE-PR-Accepted

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvithks
Copy link
Member

@joseph-v I think we used this to demonstrate PR workflow at one of the SODACODE Hacker Orientations. This may not be a valid or required PR. @sushanthakumar Please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants