Basic CRDs related to schedule based backup #1
Conversation
SrinivasChilveri
changed the title
build/Makefile.generate_proto
Outdated
| @@ -0,0 +1,84 @@ | |||
| # Copyright 2022 The SODA Authors. | |||
There was a problem hiding this comment.
IMHO, The script generates grpc boilerplate code. It can be moved out from this PR as it is not used
There was a problem hiding this comment.
yep thought of doing later, any how removed it
build/Makefile
Outdated
| @@ -0,0 +1,181 @@ | |||
| # Copyright 2022 The SODA Authors. | |||
There was a problem hiding this comment.
"Copyright 2022 The SODA Authors." -> "Copyright 2023 The SODA Authors."
Also please handle in "boilerplate.go.txt"
| ) | ||
|
|
||
| // ReclaimPolicy tells about reclamation of the backup. It can be either delete or retain | ||
| type BackupScheduleReclaimPolicyType struct { |
There was a problem hiding this comment.
IMO, BackupScheduleReclaimPolicyType can be string instead of struct
| // Valid values are: | ||
| // - "Allow": allows Backups to run concurrently; | ||
| // - "Forbid"(default): forbids concurrent runs, skipping next run if previous run hasn't finished yet. | ||
| // +optional |
There was a problem hiding this comment.
Please add default value for ConcurrentPolicy
|
|
||
| // validates the DailyPolicy | ||
| func (d *DailyPolicy) Validate() error { | ||
| err := d.CheckTimeFormat() |
There was a problem hiding this comment.
can return error here
Dockerfile
Outdated
| @@ -0,0 +1,21 @@ | |||
| # Copyright 2022 The SODA Authors. | |||
There was a problem hiding this comment.
"Copyright 2022 The SODA Authors." -> "Copyright 2023 The SODA Authors."
| // +genclient | ||
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:resource:scope=Namespaced | ||
| // +kubebuilder:subresource:status |
There was a problem hiding this comment.
IMo, SchedulePolicy does not maintain status
There was a problem hiding this comment.
it will not have any impact, but any how changed
cmd/controller-manager/main.go
Outdated
| @@ -0,0 +1,21 @@ | |||
| /* | |||
| Copyright 2022 The SODA Authors. | |||
There was a problem hiding this comment.
"Copyright 2022 The SODA Authors." -> "Copyright 2023 The SODA Authors."
controllers/doc.go
Outdated
| @@ -0,0 +1,17 @@ | |||
| /* | |||
| Copyright 2022 The SODA Authors. | |||
There was a problem hiding this comment.
"Copyright 2022 The SODA Authors." -> "Copyright 2023 The SODA Authors."
| - apiGroups: ["kahu.io"] | ||
| resources: ["backups", "backups/status"] | ||
| verbs: ["get", "list", "watch", "patch", "update", "delete"] | ||
| - apiGroups: ["*"] |
There was a problem hiding this comment.
IMO, This access might not be required
There was a problem hiding this comment.
addressed
| resourceNames: ["kahu-manager"] | ||
| resources: ["leases"] | ||
| verbs: ["get", "list", "watch", "create", "update", "delete"] | ||
| - apiGroups: [ "rbac.authorization.k8s.io" ] |
There was a problem hiding this comment.
IMO, This access might not be required
There was a problem hiding this comment.
addressed
hack/go-format.sh
Outdated
| #!/bin/bash | ||
| # | ||
| # Copyright 2023 The SODA Authors. | ||
| # Copyright 2017 the Velero contributors. |
There was a problem hiding this comment.
multiple copyright attributes?
SrinivasChilveri
force-pushed
the
BasicScheduleBasedBackup
branch
from
9fa7908
to
ed41b54
Compare
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #
Test Report Added?:
Test Report:
Special notes for your reviewer: Basic CRDs an generated code, build,compile etc