[fix] Properly emit 'connect' when using a custom namespace #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a custom namespace with a middleware, the client did not receive the 'connect' event.
darrachequesne
force-pushed
the
fix/middleware-with-initial-packet
branch
from
42466e4
to
921c30b
Compare
2 tasks
This was referenced Jan 23, 2020
This was referenced Mar 17, 2020
This was referenced Jan 10, 2023
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
…#3197) When using a custom namespace with a middleware, the client did not receive the 'connect' event. Fixes socketio#3082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a custom namespace with a middleware, the client did not receive the 'connect' event.
The kind of change this PR does introduce
Current behaviour
New behaviour
Other information (e.g. related issues)