-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for dynamic namespaces (WIP) #3195
Merged
darrachequesne
merged 2 commits into
socketio:master
from
darrachequesne:feat/dynamic-namespace-2
Mar 29, 2018
Merged
feat: add support for dynamic namespaces (WIP) #3195
darrachequesne
merged 2 commits into
socketio:master
from
darrachequesne:feat/dynamic-namespace-2
Mar 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2018
This reverts commit c0c79f0.
darrachequesne
force-pushed
the
feat/dynamic-namespace-2
branch
from
March 14, 2018 10:01
7a39fb4
to
0c16257
Compare
darrachequesne
force-pushed
the
feat/dynamic-namespace-2
branch
from
March 29, 2018 20:50
0c16257
to
9cead1e
Compare
Is there a way to pass data into next when using a function to create dynamic namespaces? |
9 tasks
This was referenced Jan 23, 2020
This was referenced Mar 17, 2020
This was referenced Jan 10, 2023
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
This follows socketio#3187, with a slightly different API. A dynamic namespace can be created with: ```js io.of(/^\/dynamic-\d+$/).on('connect', (socket) => { /* ... */ }); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
New behaviour
The following test should describe the expected behaviour:
Other information (e.g. related issues)