Calling socket.disconnect() when using xhr-polling caused an infinite loop on IE8

[taromorimoto]

Calling socket.disconnect() when using xhr-polling caused an infinite loop on IE8. Changing one line helped to solve the issue. Is this a correct fix for this or are we breaking something?

In this part of the code.

Transport.prototype.onDisconnect = function () {
    if (this.close) this.close();
    this.clearTimeouts();
    this.socket.onDisconnect();
    return this;
};

Changed this.close to this.open.

    if (this.open) this.close();

[3rd-Eden]

Looks like a good fix to me. What do you think @guille

[taromorimoto]

Great, we actually added the this.close check later. So it would be.

if (this.open && this.close) this.close();

[liamdon]

Aha, socket.io-client, in socket.io.js:1330 - got it!

[playerx]

+1 thanks @taromorimoto

[bf]

Can this somehow be changed in socket.io so I dont have to fiddle around with my npm libraries??

[sirsavary]

If this is still a problem, someone should submit a PR.