Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for underlying field for engine.io #4590

Closed
LeoDog896 opened this issue Jan 10, 2023 · 0 comments · Fixed by #4591
Closed

Add typings for underlying field for engine.io #4590

LeoDog896 opened this issue Jan 10, 2023 · 0 comments · Fixed by #4591
Labels
enhancement New feature or request

Comments

@LeoDog896
Copy link
Contributor

Currently, the underlying engine property typed is typed as any, when it should be a better type, as engine.io is written in TypeScript.

@LeoDog896 LeoDog896 added the enhancement New feature or request label Jan 10, 2023
darrachequesne pushed a commit that referenced this issue Jan 11, 2023
This adds typings for the socket.io engine field, which offers better
IntelliSense when retrieving the server, as well as more confidence on
the developer-side of what types of fields are entering the server.

Related: #4590
dzad pushed a commit to dzad/socket.io that referenced this issue May 29, 2023
This adds typings for the socket.io engine field, which offers better
IntelliSense when retrieving the server, as well as more confidence on
the developer-side of what types of fields are entering the server.

Related: socketio#4590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant