Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uwebsocketjs in socket-io server #4250

Closed
bogdankatishev opened this issue Jan 13, 2022 · 1 comment
Closed

uwebsocketjs in socket-io server #4250

bogdankatishev opened this issue Jan 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@bogdankatishev
Copy link

Hello,

I am using the code of this blog post to test the integration of uwebsocketjs in socket-io server:
https://socket.io/blog/socket-io-4-4-0/#support-for-uwebsocketjs

Everything seems to be working fine but when accessing this url: http://localhost:3000/socket.io/?EIO=4&transport=websocket (to test error handling), I receive the following error message in my console:

Error: Returning from a request handler without responding or attaching an abort handler is forbidden!
terminate called without an active exception
Aborted (core dumped)

And then it crashes the webserver.

I looked into various documentations and I tried catching the aborts but nothing seems to give me more info to resolve this issue.
@bogdankatishev bogdankatishev added the to triage Waiting to be triaged by a member of the team label Jan 13, 2022
@darrachequesne
Copy link
Member

I could indeed reproduce the bug, thanks for reporting this. Let me check.

@darrachequesne darrachequesne added bug Something isn't working and removed to triage Waiting to be triaged by a member of the team labels Jan 13, 2022
darrachequesne added a commit to socketio/engine.io that referenced this issue Jan 14, 2022
@darrachequesne
fix(uws): handle invalid websocket upgrades
8b4d6a8 
When binding to an uWebSockets.js App, there was an unhandled case that
could crash the server:

```
curl "http://localhost:3000/engine.io/?EIO=4&transport=websocket"
```

would result in:

```
Error: Returning from a request handler without responding or attaching an abort handler is forbidden!
terminate called without an active exception
```

Note: this does not apply to the default server based on ws, because
the error was caught elsewhere in the source code.

Related: socketio/socket.io#4250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darrachequesne @bogdankatishev