-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
eb5fdbd
commit 60edecb
Showing
4 changed files
with
16 additions
and
1 deletion.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60edecb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey folks, heads up that this seems to have broken testem. I'm investigating with a number of other folks in the Ember community (Ember's test infra uses testem which uses socket.io) as a bunch of our CI builds started failing today. The surfacing issue is
io.connect is not a function
: it looks like testem expectsio
to be a namespace-style object in the global namespace—it's just loading it directly via<script>
tag. I'm still poking around and trying to see exactly why and what the fix might be – reading this change, it's not obvious to me why it's serving the rolled-up ESM rather than the default globals build.60edecb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction: Testem is serving it via Express app which
require
ssocketIO
as the default CJS export and expecting that to serve it. This makes me suspect the issue is (related to?) the update to the API of engine.io in its 6.0.0.Possibly related (but, I think, not identical): #4120
[I'm opening an issue to track this and will move these comments there.]
Edit: #4121