Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed clientUri() #41

Merged
merged 1 commit into from
Jan 9, 2017
Merged

Removed clientUri() #41

merged 1 commit into from
Jan 9, 2017

Conversation

davidgatti
Copy link
Contributor

@davidgatti davidgatti commented Jan 5, 2017

Fall back to the native support of the Redis protocol URL, so we can connect to Redis using authentication. This allows us even to pass the Heroku env variable process.env.REDIS_URL and have it all working.

Verified

This commit was signed with the committer’s verified signature.
Exirel Florian Strzelecki
Fall back to the native support of the Redis protocol URL, so we can connect to Redis using authentication. This allows us even to pass the Heroku env variable process.env.REDIS_URL and have it all working.
@davidgatti davidgatti changed the title Removed clientUri() #40 Removed clientUri() Jan 5, 2017
@mishitpatel
Copy link

@rauchg Can you please help merging this PR if everything looks good ? This will allow us to pass secrets to redis server without that we can't connect. Thanks

@rauchg rauchg merged commit b494b16 into socketio:master Jan 9, 2017
@rauchg
Copy link
Contributor

rauchg commented Jan 9, 2017

LGTM

@mishitpatel
Copy link

@rauchg Thanks 👍

@davidgatti davidgatti deleted the patch-1 branch January 9, 2017 10:03
@davidgatti
Copy link
Contributor Author

@rauchg thank you :) could you also update the NPM package?

@mishitpatel
Copy link

@rauchg Would be nice if you can update NPM package as well.
Thanks again!!

@mishitpatel
Copy link

@rauchg Can you please update latest version on NPM repository ? Would be nice to get this PR updates via NPM. Thanks

@darrachequesne
Copy link
Member

Released as 1.1.0

@darrachequesne darrachequesne added this to the 1.1.0 milestone Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants