Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace - Typed Events #107

Closed
tada5hi opened this issue Dec 27, 2021 · 3 comments
Closed

Namespace - Typed Events #107

tada5hi opened this issue Dec 27, 2021 · 3 comments
Milestone
4.1.1

Comments

@tada5hi
Copy link
Contributor

tada5hi commented Dec 27, 2021

When you try to emit events to a specific namespace, the EventsMap which is possibly defined for the root Emitter instance, is not applied for the Emitter instance returned by the of method.
@tada5hi tada5hi mentioned this issue Dec 27, 2021
Closed
@tada5hi
Copy link
Contributor Author

tada5hi commented Dec 27, 2021

Would be really great if this could be available soon 😊. It is a bit annoying, to cast the return value of the of method, to have typed event support for namespaces 😅.

darrachequesne pushed a commit that referenced this issue Jan 4, 2022
@tada5hi @darrachequesne
fix(typings): fix namespace typed-events inheritence (#108)
53c73e1 
Related: #107
@darrachequesne
Copy link
Member

This should be fixed by 53c73e1, included in @socket.io/[email protected]. Thanks!

@darrachequesne darrachequesne added this to the 4.1.1 milestone Jan 4, 2022
@tada5hi
Copy link
Contributor Author

tada5hi commented Jan 5, 2022

Your welcome 🤗, have a nice week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
2 participants
@darrachequesne @tada5hi