Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable exponential backoff #1149

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Add configurable exponential backoff #1149

merged 3 commits into from
Jan 14, 2019

Conversation

headlessme
Copy link
Contributor

@headlessme headlessme commented Jan 12, 2019

Added a basic exponential backoff algorithm to the reconnect logic. It supports jittering via randomizationFactor, and limiting the max interval via reconnectWaitMax.

@nuclearace
Copy link
Member

Nice! Could you do me a favor, and add an entry for v14.0.0 in the changelog detailing this addition? It just so happened I was about to release a new one soon.

@headlessme
Copy link
Contributor Author

How does that look?

@nuclearace nuclearace merged commit 4c98c24 into socketio:development Jan 14, 2019
@nuclearace
Copy link
Member

Excellent thanks! I should be releasing a new version sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants