Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection URLs encoding for '^' symbol #894

Closed
MaxAdamyan opened this issue Dec 5, 2017 · 0 comments
Closed

Connection URLs encoding for '^' symbol #894

MaxAdamyan opened this issue Dec 5, 2017 · 0 comments
Labels
bug patched

Comments

@MaxAdamyan
Copy link

When percent encoding URLs use default CharacterSets, or at least include ^ symbol to allowedURLCharacterSet extension.
Because string like ^ symbol is not ok in your connectParams will cause a crash on URLComponents.percentEncodedQuery setter.
@nuclearace nuclearace added the bug label Dec 5, 2017
nuclearace added a commit that referenced this issue Jan 10, 2018
@nuclearace
Merge branch 'development'
ea93e69 
* development:
  fix insert invoked twice
  add , to disconnect
  update changelog
  Fix #923
  update reconnect documentation
  update starscream
  Fix #894
@marinh marinh mentioned this issue Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug patched
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nuclearace @MaxAdamyan