SocketManger.config #1078
Labels
Comments
|
Yeah this looks like a bug. |
nuclearace
added a commit
that referenced
this issue
Aug 30, 2018
|
Wow, fixed very fast :D |
Merged
nuclearace
added a commit
that referenced
this issue
Oct 4, 2018
* development: update changelog and bump pod version check for 200 status code when polling #857 update xcode versino set the right URL in websocket creation fix cookies import when create the websocket Be sure to keep secure config even if config is changed. Fix #1078 Don't need to write DispatchTime use while let instead of while and if let
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I think there is a small issue when the SocketManager.config is modified.
Here is my test, I initialise the SocketManager as follows:
self.socketManager = SocketManager(socketURL: URL(string: "https://example.com")!, config: [ .log(false), .compress ])Then I update the config and add the connectParams:
self.socketManager?.config = [ .connectParams(connectParameters) ]At this point when i Try to connect, the SocketManager removes the secure flag and tries to connect to "http://example.com" rather than "https://example.com"
I have to explicit pass the secure(true) param when modifying the config like this:
self.socketManager?.config = [ .secure(true), .connectParams(connectParameters) ]I think this is probably a bug because if I pass the connectParams on the initialisation and I don't change the config it works without passing secure(true).
The text was updated successfully, but these errors were encountered: