Fixing concurrency and thread issues in engine.io #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rver causing null pointer exception.
…read safe. This would cause the server threads to choke when many clients were connecting quickly.
…lient would send a new long poll request too quickly.
…y client connected.
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 86.33% 86.31% -0.02%
==========================================
Files 11 12 +1
Lines 578 592 +14
Branches 89 90 +1
==========================================
+ Hits 499 511 +12
- Misses 40 41 +1
- Partials 39 40 +1 |
trinopoty
reviewed
Nov 28, 2019
engine.io-server/src/main/java/io/socket/engineio/server/EngineIoServer.java
Outdated
Show resolved
Hide resolved
engine.io-server/src/main/java/io/socket/engineio/server/EngineIoSocket.java
Outdated
Show resolved
Hide resolved
engine.io-server/src/main/java/io/socket/engineio/server/EngineIoSocket.java
Outdated
Show resolved
Hide resolved
1) Added synchronized to resetPingTimeout method 2) Moved the runnable definition to a final field on socket object 3) Changed the TreeMap wrapped in synchronization to a ConcurrentHashMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I spent a few weeks investigating and load testing the engine.io-java server for a project. During this time I found and fixed several issues to do with concurrency, race conditions and the TimerTasks.
In the end I decided not to continue with engine.io but thought I'd push up my fixes that I found.
Hope this helps.