This repository has been archived by the owner on Jul 28, 2020. It is now read-only.
Milestone hooks! #916
Merged
Milestone hooks! #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ButtonTest remove describe.only
Hooks useTheme
conor-cafferkey-sociomantic
force-pushed
the
Milestone-Hooks!
branch
from
a96d95c to
9e6c705
Compare
damian-rodriguez-sociomantic
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
I've pushed a commit removing some forcehover leftovers, I found a few more things but are tiny issues not related to Miestone-Hooks!, I'll open separate issues for those, other than that, LGTM
edit: PopperWrapper has to be converted
…pe changed to bool
…sie-ui into Milestone-Hooks!
|
GitHub won’t let me review this PR since I’m the one who opened it 😄 I think we’re good to go once PopperWrapper is converted 🚀 |
…perHooks Issue 919 popper wrapper hooks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone-Hooks!:
useThemeanduseIdcustom hooksmaster