Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#35) Add --pager option for diff.interactiveFilter #391

Closed
wants to merge 1 commit into from
Closed

(#35) Add --pager option for diff.interactiveFilter #391

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2020

Fix #35

This PR changes below.

  • If user supplies --pager option, dfs won't custom meta lines.

ss 3

Usecase

[interactive]
	diffFilter = diff-so-fancy --pager

Motivation

I'm a contributor of git-delta and solved the same problem. I found #35 issue today and did a same approach.

Remarks

I'd like to add a test. In order to test, we need to confirm each outputs below have same line-number.

# for input
git diff-files -p --no-color

# for output
git diff-files -p --color | diff-so-fancy --pager

However, I'm not familiar with bats, and bats seems not to able to achieve .... Is there any good suggestion to add a test? (With the hardest way, we need to prepare diff outputs text file.)

@ghost
Copy link
Author

ghost commented Dec 7, 2020

Sorry, I didn't notice somebody had already created same PR 14 hours ago.
I'm gonna close this.

@ghost ghost closed this Dec 7, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git add --patch does not use diff-so-fancy
0 participants