chore: Test snyk/scan commands with additional-arguments #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencord0
force-pushed
the
additional-monitor-arguments
branch
7 times, most recently
from
e267dd8
to
bc2726b
Compare
bencord0
force-pushed
the
additional-monitor-arguments
branch
from
bc2726b
to
2c3d55b
Compare
bastiandoetsch
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crux of this commit is this line.
A new parameter is created,
test-only-param_dry-run-commands, which installs a shim to capture the command arguments passed to thesnykCLI.Then, a validation step is run that compares the output of the commands the orb will run, vs the
expected-commands.An exact match string comparison is used, to set the result.