Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of custom service annotations #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philchristensen
Copy link

Our Kubernetes infrastructure only allows for private load balancers, so we needed to be able to add an annotation to the service object to make it private.

It was also useful for adding another annotation to the service which defined the external DNS name for the generated ELB.

    service:
      brokerType: LoadBalancer
    serviceAnnotations:
      service.beta.kubernetes.io/aws-load-balancer-internal: 'true'
      external-dns.alpha.kubernetes.io/hostname: snyk.example.com

@philchristensen philchristensen requested a review from a team as a code owner May 13, 2022 16:06
@CLAassistant
Copy link

CLAassistant commented Sep 20, 2022

CLA assistant check
All committers have signed the CLA.

@mjhuber
Copy link

mjhuber commented Sep 21, 2022

+1 this would be extremely helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants