Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use api v3 get all projects endpoint #342

Merged
merged 1 commit into from
Jul 11, 2022
Merged

feat: use api v3 get all projects endpoint #342

merged 1 commit into from
Jul 11, 2022

Conversation

mathild3r
Copy link
Contributor

@mathild3r mathild3r commented Jun 22, 2022 •
edited
Loading

  • Tests written and linted ℹ︎
  • Documentation written in Wiki/README
  • Commit history is tidy & follows Contributing guidelines ℹ︎

What this does

Using the API v3 instead of v1 to get the project list.
Tested manually as well as local regression.

lili2311
lili2311 suggested changes Jun 22, 2022
View reviewed changes
docs/import.md Outdated Show resolved Hide resolved
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
src/lib/get-snyk-host.ts Outdated Show resolved Hide resolved
src/scripts/generate-imported-targets-from-snyk.ts Outdated Show resolved Hide resolved
test/lib/org.test.ts Outdated Show resolved Hide resolved
test/scripts/generate-imported-targets-from-snyk.test.ts Outdated Show resolved Hide resolved
test/scripts/generate-imported-targets-from-snyk.test.ts Outdated Show resolved Hide resolved
@mathild3r mathild3r force-pushed the feat/ChangeToApiV3 branch from d70c0af to b92217f Compare June 24, 2022 13:39
@mathild3r mathild3r marked this pull request as ready for review June 30, 2022 11:03
@mathild3r mathild3r requested a review from a team as a code owner June 30, 2022 11:03
lili2311
lili2311 reviewed Jun 30, 2022
View reviewed changes
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
@lili2311 lili2311 mentioned this pull request Jun 30, 2022
Merged
3 tasks
@mathild3r mathild3r force-pushed the feat/ChangeToApiV3 branch from bf23f3b to 4c7743b Compare July 1, 2022 13:40
lili2311
lili2311 reviewed Jul 1, 2022
View reviewed changes
docs/import.md Outdated Show resolved Hide resolved
lili2311
lili2311 suggested changes Jul 1, 2022
View reviewed changes
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
lili2311
lili2311 reviewed Jul 1, 2022
View reviewed changes
src/lib/api/org/index.ts Outdated Show resolved Hide resolved
@mathild3r mathild3r force-pushed the feat/ChangeToApiV3 branch 3 times, most recently from 1d80c61 to 9a1a370 Compare July 4, 2022 13:53
@mathild3r mathild3r force-pushed the feat/ChangeToApiV3 branch 2 times, most recently from 9a866e3 to 9b37011 Compare July 7, 2022 13:49
lili2311
lili2311 previously approved these changes Jul 8, 2022
View reviewed changes
@mathild3r mathild3r force-pushed the feat/ChangeToApiV3 branch from 9b37011 to 9a6f328 Compare July 11, 2022 08:54
@mathild3r mathild3r merged commit 835d64b into master Jul 11, 2022
@mathild3r mathild3r deleted the feat/ChangeToApiV3 branch July 11, 2022 09:29
@aarlaud
Copy link
Contributor

aarlaud commented Jul 11, 2022

🎉 This PR is included in version 1.91.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lili2311 lili2311 lili2311 approved these changes

Assignees

@mathild3r mathild3r

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathild3r @aarlaud @lili2311