Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve bitbucket cloud api calls #321

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

IlanTSnyk
Copy link
Contributor

@IlanTSnyk IlanTSnyk commented Apr 20, 2022

  • Tests written and linted ℹ︎
  • Documentation written in Wiki/README
  • Commit history is tidy & follows Contributing guidelines ℹ︎

What this does

Improves the BBC API calls to send less calls that fetch more data each by adding the pagelen var into the calls

@IlanTSnyk IlanTSnyk requested a review from a team as a code owner April 20, 2022 09:07
@IlanTSnyk IlanTSnyk self-assigned this Apr 20, 2022
@IlanTSnyk
Copy link
Contributor Author

The current tests are a level higher than that: they use the full function that doesn't accept the pagelen var but I can change the functions to expect that var and pass it each time when the function is called and then I can revise the tests to cover that too.

@lili2311 lili2311 merged commit ebd183f into master Apr 22, 2022
@lili2311 lili2311 deleted the feat/improve-bitbucket-cloud-api-calls branch April 22, 2022 16:18
@aarlaud
Copy link
Contributor

aarlaud commented Apr 22, 2022

🎉 This PR is included in version 1.82.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants