fix: backoff function error handling #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcombuechen
reviewed
Jan 9, 2025
| @@ -111,12 +111,15 @@ func GetPackageVulnerabilities(cfg *Config, purl *packageurl.PackageURL, auth *s | |||
| func getRetryClient(logger *zerolog.Logger) *http.Client { | |||
| rc := retryablehttp.NewClient() | |||
| rc.Logger = nil | |||
| rc.ErrorHandler = retryablehttp.PassthroughErrorHandler | |||
There was a problem hiding this comment.
is this needed to handle resp == nil?
There was a problem hiding this comment.
no, instead what this does is propagate the last error message to the user. i.e instead of just seeing giving up after x attempts they'll get more details
paulrosca-snyk
force-pushed
the
fix/backoff-function
branch
from
15938c5 to
2c4595a
Compare
mcombuechen
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the
Backofffunction of theretryablehttpclient, the responses will benilif an error occurs. This PR addresses this issue and also adds thePassthroughErrorHandlerto the client in order to propagate more error details.