Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Python scanning, new plugin interfaces #715

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

kyegupov
Copy link
Contributor

@kyegupov kyegupov commented Aug 6, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Picks up new versions of plugins to ensure they are being tested.
Also, the Python plugin now can scan "setup.py" and also properly picks up the dependencies that have a python_version condition on them.

@kyegupov kyegupov requested a review from a team as a code owner August 6, 2019 17:25
@kyegupov kyegupov self-assigned this Aug 6, 2019
@ghost ghost requested review from lili2311 and miiila August 6, 2019 17:25
@kyegupov kyegupov force-pushed the fix/plugin-version-bumps branch from ae0f6e6 to 04c796f Compare August 7, 2019 09:22
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyegupov kyegupov changed the title fix: upgraded plugin versions (no user-visible changes) feat: improve Python scanning, new plugin interfaces Aug 8, 2019
@kyegupov kyegupov force-pushed the fix/plugin-version-bumps branch from 04c796f to 0d16d7a Compare August 8, 2019 10:25
@kyegupov
Copy link
Contributor Author

kyegupov commented Aug 8, 2019

This seems to be blocked on snyk/snyk-cli-interface#17

@kyegupov kyegupov force-pushed the fix/plugin-version-bumps branch from 0d16d7a to c575262 Compare August 8, 2019 17:09
@kyegupov kyegupov force-pushed the fix/plugin-version-bumps branch from c575262 to b35d617 Compare August 8, 2019 17:22
@kyegupov kyegupov merged commit 0082f91 into master Aug 9, 2019
@kyegupov kyegupov deleted the fix/plugin-version-bumps branch August 9, 2019 09:10
@snyksec
Copy link

snyksec commented Aug 9, 2019

🎉 This PR is included in version 1.214.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants