Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade snyk-docker-plugin and snyk-policy #5587

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Nov 19, 2024

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

A hot fix release to address 3 bugs affecting 1.1294.0

Note: The snyk-docker-plugin is being installed from a GitHub tag as there are changes on +6.13.2 which can not be released until December.

@thisislawatts thisislawatts changed the base branch from main to release-candidate November 19, 2024 16:26
@thisislawatts thisislawatts marked this pull request as ready for review November 19, 2024 16:39
@thisislawatts thisislawatts requested a review from a team as a code owner November 19, 2024 16:39
Copy link
Contributor

Warnings
⚠️ There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 96d3ec9

Copy link
Contributor

@cmars cmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I reviewed the dependency changes brought in by this:

Did not see any obviously breaking changes. Looks like we're either fixing stuff that was just broken, or addressing false positives.

Assuming the ignored dependencies in .snyk are transitive vulns brought in by these dependencies?

In any case LGTM.

@thisislawatts thisislawatts merged commit 8597aab into release-candidate Nov 19, 2024
7 checks passed
@thisislawatts thisislawatts deleted the hot-fix-v1.1294.0 branch November 19, 2024 21:16
@thisislawatts
Copy link
Member Author

thisislawatts commented Nov 19, 2024

Assuming the ignored dependencies in .snyk are transitive vulns brought in by these dependencies?

The ignored vuln is a new one published in the last 7 days, so whilst we have triaged it with an ignore on main branch the vuln is "unhandled" on release-candidate branch.
https://security.snyk.io/vuln/SNYK-JS-SOURCEMAPSUPPORT-6112477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants