Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [OSM-855] fixed python 3.12 support in snyk-python-plugin #4965

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

gemaxim
Copy link
Contributor

@gemaxim gemaxim commented Dec 13, 2023

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Bumped snyk-python-plugin to fix python 3.12 support.

Where should the reviewer start?

Acceptance test for python version specifier 3.12.

How should this be manually tested?

/bin/snyk test --command=python3 with python 3.12 installed on your machine as default for python 3.

Any background context you want to provide?

All of the actual support is nested in the snyk-python-plugin. The already existing python - pip and pipenv acceptance tests should cover the changes.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/OSM-855

Risk

Low. It's already tested and working in the plugin: https://github.com/snyk/snyk-python-plugin/blob/main/.circleci/config.yml#L132 - python version (previously not tested) was added to the pipeline test job and works for all pre-existing tests: https://github.com/snyk/snyk-python-plugin/tree/main/test.

@gemaxim gemaxim self-assigned this Dec 13, 2023
@gemaxim gemaxim force-pushed the fix/OSM-855/python-3.12-support-fix branch from fc3d232 to 041644a Compare December 13, 2023 09:15
@gemaxim gemaxim marked this pull request as ready for review December 13, 2023 11:39
@gemaxim gemaxim requested review from a team as code owners December 13, 2023 11:39
@bastiandoetsch
Copy link
Contributor

Hey @gemaxim, thanks for the PR - would you please use & fill-out the PR template so we can start the review?

@gemaxim
Copy link
Contributor Author

gemaxim commented Dec 13, 2023

Hey @gemaxim, thanks for the PR - would you please use & fill-out the PR template so we can start the review?

Hey @bastiandoetsch , I just filled the PR template. Let me know if there are any questions.

@gemaxim gemaxim merged commit 62175e6 into master Dec 13, 2023
14 checks passed
@gemaxim gemaxim deleted the fix/OSM-855/python-3.12-support-fix branch December 13, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants