Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: check if the platform is supported #4377

Merged
merged 1 commit into from
Feb 1, 2023
Merged

chore: check if the platform is supported #4377

merged 1 commit into from
Feb 1, 2023

Conversation

PeterSchafer
Copy link
Collaborator

@PeterSchafer PeterSchafer commented Jan 31, 2023 •
edited
Loading

What does this PR do?

Introduces a check and warning if the platform the CLI runs on is actually not supported.

Screenshots

Example of the message. The shown platform is supported.
image

@PeterSchafer PeterSchafer requested review from a team as code owners January 31, 2023 16:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023 •
edited
Loading

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against c2bd650

@PeterSchafer PeterSchafer marked this pull request as draft January 31, 2023 16:15
@PeterSchafer PeterSchafer force-pushed the chore/HEAD-82_add_warning branch from 4b36b83 to 9979c20 Compare February 1, 2023 10:14
@PeterSchafer PeterSchafer force-pushed the chore/HEAD-82_add_warning branch from 9979c20 to c2bd650 Compare February 1, 2023 11:02
@PeterSchafer PeterSchafer marked this pull request as ready for review February 1, 2023 11:02
@PeterSchafer PeterSchafer merged commit f433592 into master Feb 1, 2023
@PeterSchafer PeterSchafer deleted the chore/HEAD-82_add_warning branch February 1, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

@dekelund dekelund Awaiting requested review from dekelund dekelund was automatically assigned from snyk/snyk-open-source

@klesniewski klesniewski Awaiting requested review from klesniewski klesniewski was automatically assigned from snyk/snyk-open-source

@tonidevine1 tonidevine1 Awaiting requested review from tonidevine1 tonidevine1 was automatically assigned from snyk/snyk-open-source

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterSchafer @bastiandoetsch