refactor: use IacTestFlags type instead of generic Options #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipapast
commented
Aug 17, 2022
YairZ101
approved these changes
Aug 18, 2022
ofekatr
approved these changes
Aug 18, 2022
ipapast
force-pushed
the
refactor/update-iac-types
branch
from
976567f to
51a3b00
Compare
ipapast
force-pushed
the
refactor/update-iac-types
branch
from
51a3b00 to
f93b562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm suggesting this change for using only the subset of types we actually need. this will also help the next PR which needs the Policy Options to be used at a later point in code. #3602