fix: increase buffer size #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekatr
reviewed
Aug 17, 2022
src/lib/iac/test/v2/scan/index.ts
Outdated
| @@ -53,6 +53,7 @@ function scanWithConfig( | |||
| const process = childProcess.spawnSync(policyEnginePath, args, { | |||
| encoding: 'utf-8', | |||
| stdio: 'pipe', | |||
| maxBuffer: 1024 * 1024 * 10, | |||
There was a problem hiding this comment.
Do you know what value was originally being used?
Do we know how bigger the buffer's cap just became?
Why was this value chosen in particular?
YairZ101
commented
Aug 17, 2022
src/lib/iac/test/v2/scan/index.ts
Outdated
| @@ -53,6 +53,7 @@ function scanWithConfig( | |||
| const process = childProcess.spawnSync(policyEnginePath, args, { | |||
| encoding: 'utf-8', | |||
| stdio: 'pipe', | |||
| maxBuffer: 1024 * 1024 * 10, | |||
There was a problem hiding this comment.
The default value is 1024 * 1024, if we see in the future that multiplying it by 10 is not enough we can increase it further.
YairZ101
force-pushed
the
fix/increase-buffer-size
branch
from
06aadca to
8079fe3
Compare
ofekatr
approved these changes
Aug 17, 2022
|
@YairZ101 Can you please share this solution with #cli for visibility? |
|
@ofekatr why do you think we should post this in #cli? this PR doesn't affect the CLI as a whole. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR fixes the problem where in some cases when scanning a directory with a high number of files, the scan failed due to an ENOBUFS error.
The fix is rather simple, it simply increases the max buffer.