Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add helper for returning vulnerability URLs #3590

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix: add helper for returning vulnerability URLs #3590

merged 1 commit into from
Aug 15, 2022

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Aug 15, 2022 •
edited
Loading

What does this PR do?

Update the vulnerability URL generation so that it differentiates between license and security issues. License issues should resolve to a 301 redirect, where as security issues have their own page on https://security.snyk.io

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@thisislawatts thisislawatts self-assigned this Aug 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022 •
edited
Loading

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/formatters/legacy-format-issue.ts

Generated by 🚫 dangerJS against 8a46931

JackuB
JackuB approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@JackuB JackuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more for the Snyk Open Source to review, but approving from what I can see.

@thisislawatts thisislawatts marked this pull request as ready for review August 15, 2022 11:59
@thisislawatts thisislawatts requested review from a team as code owners August 15, 2022 11:59
@thisislawatts thisislawatts force-pushed the fix/correct-url-for-vulnerability-issues branch 2 times, most recently from 53bc43f to b359bb8 Compare August 15, 2022 12:14
@thisislawatts
fix: correct broken URLs for license issues
8a46931 
Update the vulnerability URL generation so that it differentiates between license and security issues.
License issues should resolve to a 301 redirect, where as security issues have
their own page on https://security.snyk.io
@thisislawatts thisislawatts force-pushed the fix/correct-url-for-vulnerability-issues branch from b359bb8 to 8a46931 Compare August 15, 2022 12:18
@thisislawatts thisislawatts merged commit 6c9cd2c into master Aug 15, 2022
@thisislawatts thisislawatts deleted the fix/correct-url-for-vulnerability-issues branch August 15, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitphill gitphill gitphill approved these changes

@JackuB JackuB JackuB approved these changes

@ZahirJ ZahirJ Awaiting requested review from ZahirJ ZahirJ was automatically assigned from snyk/snyk-open-source

@robcresswell robcresswell Awaiting requested review from robcresswell robcresswell was automatically assigned from snyk/snyk-open-source

@florindumitrascu florindumitrascu Awaiting requested review from florindumitrascu florindumitrascu was automatically assigned from snyk/snyk-open-source

Assignees

@thisislawatts thisislawatts

Labels
🌔 Apollo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisislawatts @JackuB @gitphill