test: increase analytics test timeout #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2021 18:39
This spy is never called as we're executing code outside the process.
Launching process alone takes 5 seconds which is the default timeout.
ghost
force-pushed
the
test/analytics-fix
branch
from
cb97952 to
2735bce
Compare
ghost
force-pushed
the
test/analytics-fix
branch
from
2735bce to
8e296a6
Compare
ghost
commented
Aug 11, 2021
| @@ -27,7 +30,7 @@ describe('analytics module', () => { | |||
| }); | |||
|
|
|||
| afterEach(() => { | |||
| jest.restoreAllMocks(); | |||
| server.clearRequests(); | |||
There was a problem hiding this comment.
Added this as we should typically clear state between tests so we aren't asserting on invalid state.
| import * as request from '../../../src/lib/request'; | ||
| import * as fs from 'fs'; | ||
|
|
||
| jest.setTimeout(1000 * 30); |
There was a problem hiding this comment.
This is the main thing to avoid test timeouts.
Comment on lines
+311
to
+313
|
|
||
| const lastRequest = server.popRequest(); | ||
| expect(lastRequest).toBeUndefined(); |
There was a problem hiding this comment.
Spying won't work as spies are bound to the current Node context; which is Jest. We are launching Snyk CLI in its own process where the spy does not exist.
To test this correctly, we can ensure fakeServer didn't receive a request.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launching process alone takes 5 seconds which is the default timeout. Causes unreliable tests.
https://app.circleci.com/pipelines/github/snyk/snyk/6706/workflows/1ae30a6e-a106-4d71-a337-dffd58512a09/jobs/44733
Also made some small fixes (see commits).