Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cli use Cabal 2.2 #38

Merged
merged 3 commits into from
Mar 14, 2018
Merged

Make cli use Cabal 2.2 #38

merged 3 commits into from
Mar 14, 2018

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Mar 13, 2018

This "solves" #26 and #37 if -p / --preferred is passed. That causes index to be traversed twice (which probably makes whole index to be retained in memory, but it's ok on current machines).

I don't have time right now to update the yesod app, so if someone is willing to pick this up, please do

phadej added 2 commits March 13, 2018 14:59
Also change to use PackageName and Version instead of String
@phadej
Copy link
Collaborator Author

phadej commented Mar 13, 2018

last commits makes residency small (but "obviously" only in non--p case)

@phadej
Copy link
Collaborator Author

phadej commented Mar 13, 2018

With this patch packdeps-cli allocates more in total, if someone have time to profile what exactly, that would be great to know as well.

Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 8ba67f4 into snoyberg:web Mar 14, 2018
@phadej phadej deleted the Cabal-2.2 branch March 14, 2018 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants