Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled native groupBy for vector #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BebeSparkelSparkel
Copy link
Collaborator

groupBy been available since vector-0.13.0.0
closes #251

groupBy been available since vector-0.13.0.0
closes snoyberg#251
@BebeSparkelSparkel
Copy link
Collaborator Author

@jcmartin Since you were sort of involved with this. Could you review this?

@jcmartin
Copy link
Contributor

jcmartin commented Nov 28, 2024

@BebeSparkelSparkel I added my small nitpicks. I think the bigger thing we should do is consider adding a 9.8.3 release from stackage to the continuous integration. This will require a nightly as there is no lts for the 9.8 series yet.

@BebeSparkelSparkel
Copy link
Collaborator Author

@jcmartin Sorry, I do not see your nitpicks.

If you have any changes you want to make for the workflows, I'll review them in a PR. Thanks

@jcmartin
Copy link
Contributor

jcmartin commented Dec 4, 2024

The nitpick is that cause should be @cause. That is all.

@@ -1218,7 +1222,11 @@ instance U.Unbox a => IsSequence (U.Vector a) where
unsnoc v
| U.null v = Nothing
| otherwise = Just (U.init v, U.last v)
--groupBy = U.groupBy
#if MIN_VERSION_vector(0,13,0)
-- | since 1.0.21.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean @since. There are a few instances of this.

@@ -1067,7 +1067,11 @@ instance IsSequence (V.Vector a) where
unsnoc v
| V.null v = Nothing
| otherwise = Just (V.init v, V.last v)
--groupBy = V.groupBy
#if MIN_VERSION_vector(0,13,0)
-- | since 1.0.21.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@since instead of since.

@@ -1291,7 +1299,11 @@ instance VS.Storable a => IsSequence (VS.Vector a) where
unsnoc v
| VS.null v = Nothing
| otherwise = Just (VS.init v, VS.last v)
--groupBy = U.groupBy
#if MIN_VERSION_vector(0,13,0)
-- | since 1.0.21.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@since instead of since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native groupBy functions not being used in IsSequence instances
2 participants