-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled native groupBy
for vector
#252
base: master
Are you sure you want to change the base?
Enabled native groupBy
for vector
#252
Conversation
groupBy been available since vector-0.13.0.0 closes snoyberg#251
@jcmartin Since you were sort of involved with this. Could you review this? |
@BebeSparkelSparkel I added my small nitpicks. I think the bigger thing we should do is consider adding a 9.8.3 release from stackage to the continuous integration. This will require a |
@jcmartin Sorry, I do not see your nitpicks. If you have any changes you want to make for the workflows, I'll review them in a PR. Thanks |
The nitpick is that |
@@ -1218,7 +1222,11 @@ instance U.Unbox a => IsSequence (U.Vector a) where | |||
unsnoc v | |||
| U.null v = Nothing | |||
| otherwise = Just (U.init v, U.last v) | |||
--groupBy = U.groupBy | |||
#if MIN_VERSION_vector(0,13,0) | |||
-- | since 1.0.21.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean @since
. There are a few instances of this.
@@ -1067,7 +1067,11 @@ instance IsSequence (V.Vector a) where | |||
unsnoc v | |||
| V.null v = Nothing | |||
| otherwise = Just (V.init v, V.last v) | |||
--groupBy = V.groupBy | |||
#if MIN_VERSION_vector(0,13,0) | |||
-- | since 1.0.21.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@since
instead of since
.
@@ -1291,7 +1299,11 @@ instance VS.Storable a => IsSequence (VS.Vector a) where | |||
unsnoc v | |||
| VS.null v = Nothing | |||
| otherwise = Just (VS.init v, VS.last v) | |||
--groupBy = U.groupBy | |||
#if MIN_VERSION_vector(0,13,0) | |||
-- | since 1.0.21.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@since
instead of since
.
groupBy been available since vector-0.13.0.0
closes #251