Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

remove superfluous -fno-{ignore, omit}-interface-pragmas #675

Closed

Conversation

alpmestan
Copy link
Collaborator

As suggested by @sighingnow in #674 (comment). I ran the testsuite after I wrote this patch, and this doesn't affect anything.

Copy link
Owner

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More simplifications, awesome!

@alpmestan
Copy link
Collaborator Author

Hmm, this does re-introduce the "can't use Natural in base" error when built with quickest (I forgot to try that, I've mostly been building perf-flavoured GHCs lately for the testsuite work).

Should we make this conditional on the flavour for now, until the underlying problem is solved in GHC land, if ever?

https://github.com/snowleopard/hadrian/blob/master/doc/flavours.md#arguments says we are likely to encounter this problem with quick, quickest and prof (since they build with -O0). Should emit those flags that this patch removes whenever the flavour is one of those? It's quite a hack, anyone's got a better idea?

@snowleopard
Copy link
Owner

Should we add the workarounds directly into flavour descriptions, e.g. here?

https://github.com/snowleopard/hadrian/blob/master/src/Settings/Flavours/Quickest.hs#L17

@alpmestan
Copy link
Collaborator Author

Yes, that would be nice!

We can still filter on the input file etc there, right? We could this way define the list of flags at the toplevel somewhere, with proper docs pointing to the trac ticket, and use that in all the relevant flavour definitions. That does sound better.

@snowleopard
Copy link
Owner

Yep, we can use all predicates there too.

@alpmestan
Copy link
Collaborator Author

OK, I'm closing this PR since the solution we're going for is "different enough" to justify a new one.

@alpmestan alpmestan closed this Sep 5, 2018
@alpmestan alpmestan deleted the alp/remove-superfluous-flags branch September 5, 2018 13:10
@alpmestan
Copy link
Collaborator Author

Better patch implementing the idea from above in #676.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants