SNOW-824475 Support Spark 3.4 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 89.59% 89.52% -0.07%
==========================================
Files 52 52
Lines 4487 4487
Branches 744 741 -3
==========================================
- Hits 4020 4017 -3
- Misses 467 470 +3 |
sfc-gh-mrui
force-pushed
the
mrui_spark34
branch
2 times, most recently
from
400c86f to
c1d7b56
Compare
sfc-gh-mrui
requested review from
sfc-gh-sshankar,
sfc-gh-ema and
sfc-gh-bli
as code owners
sfc-gh-mrui
changed the title
sfc-gh-zli
approved these changes
May 22, 2023
| |( SELECT * FROM ( SELECT * FROM ( $test_table2 ) AS | ||
| |"SF_CONNECTOR_QUERY_ALIAS" ) AS "SUBQUERY_0" WHERE | ||
| |( "SUBQUERY_0"."O" IS NOT NULL ) ) AS "SUBQUERY_1" | ||
| """.stripMargin |
There was a problem hiding this comment.
If I understand correctly, we issue two SQLs now instead of one for this push down? Is that a performance issue?
There was a problem hiding this comment.
This is test-only and it doesn't cause any perf problem for production.
- The generated query for different spark may be different.
- To make the test case to work for different Spark versions, the
expectedMultiplyQueriesincludes the query for spark 3.4 and previous version. If the query matches either one, the test case will succeed.
arthurli1126
pushed a commit
to arthurli1126/spark-snowflake
that referenced
this pull request
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-824475 Support Spark 3.4
The main changes for Spark 3.4 affects Spark Connector are:
CastansiEnabled: BooleanevalMode: EvalMode.ValueLEGACY,ANSI,TRYLEGACY. It will make SC to be in consistent behaviour.JoinHintargument forScalarSubquery.PromotePrecisionis removed from Spark 3.4ansiEnabledforRound.