-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1887892: improve process pool + thread pool logic, add retry logic #2924
base: dev/data-source
Are you sure you want to change the base?
Conversation
…not wait, add retry logic
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
) | ||
for i, query in enumerate(partitioned_queries) | ||
] | ||
for future in as_completed(process_pool_futures): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious how does this as_completed
work?
let's say I have 10 futures, and 7th job finishes first, would as_completed(process_pool_futures)
return 7th job first?
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
…not wait, add retry logic
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1887892
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
this PR meant to do two things:
i. decouple process pool download and thread pool upload/copy into table
ii. add retry logic for both process pool and thread pool
test for partition download will be added in other PR