SNOW-1893703: Require SQL counter for local Snowpark pandas integration tests. #2918
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on tests. Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
added
NO-CHANGELOG-UPDATES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we required SQL count checks in Github Actions
but not when running tests locally or on Jenkins. I have been surprised
many times to see my tests pass locally and fail in GitHub Actions
because they're missing sql count checks.
In this commit, require the count checks for local test runs, but leave
them as not required for Jenkins tests.