Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1852779 Fix AST encoding for Column in_, asc, and desc #2756

Merged
merged 1 commit into from
Dec 16, 2024
Merged

SNOW-1852779 Fix AST encoding for Column in_, asc, and desc #2756

merged 1 commit into from
Dec 16, 2024

Conversation

sfc-gh-vbudati
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1852779

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

Fixed AST encoding for Column in_, asc, and desc. Removed an unused entity and renamed sp_column_in__seq to sp_column_in. Changed the nulls_first optional boolean param to be an enum.

@sfc-gh-vbudati sfc-gh-vbudati added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-ast Change materially affects the Snowpark AST labels Dec 12, 2024
@sfc-gh-vbudati sfc-gh-vbudati requested review from a team as code owners December 12, 2024 23:46
sfc-gh-lspiegelberg
sfc-gh-lspiegelberg reviewed Dec 16, 2024
View reviewed changes
src/snowflake/snowpark/column.py
@@ -644,7 +644,7 @@ def in_(
ast = None
if _emit_ast:
ast = proto.Expr()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the IR server-side branch for this already merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

sfc-gh-lspiegelberg
sfc-gh-lspiegelberg reviewed Dec 16, 2024
View reviewed changes
tests/ast/data/windows.test
@@ -557,6 +557,9 @@ body {
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test for this where it is false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't be "false" -- it's an enum. It can only be set to true but this should be tested by the asc/desc tests.

sfc-gh-lspiegelberg
sfc-gh-lspiegelberg approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-vbudati sfc-gh-vbudati merged commit 2fcf2ff into main Dec 16, 2024
46 checks passed
@sfc-gh-vbudati sfc-gh-vbudati deleted the vbudati/SNOW-1852779-fix-col-asc-desc-in branch December 16, 2024 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azwiegincew sfc-gh-azwiegincew sfc-gh-azwiegincew approved these changes

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg sfc-gh-lspiegelberg approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-ast Change materially affects the Snowpark AST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-vbudati @sfc-gh-lspiegelberg @sfc-gh-azwiegincew