Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make typing-extensions a required dependency #273

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Make typing-extensions a required dependency #273

merged 3 commits into from
Mar 23, 2022

Conversation

sfc-gh-sfan
Copy link
Collaborator

No description provided.

@sfc-gh-sfan sfc-gh-sfan requested a review from a team March 22, 2022 20:52
@sfc-gh-sfan sfc-gh-sfan changed the title Add check for typing_extensions Make typing-extensions a required dependency Mar 23, 2022
@sfc-gh-sfan sfc-gh-sfan merged commit 95ab331 into master Mar 23, 2022
@sfc-gh-sfan sfc-gh-sfan deleted the shixuan_check branch March 23, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-yixie sfc-gh-yixie sfc-gh-yixie approved these changes

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-kwagner sfc-gh-kwagner sfc-gh-kwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-sfan @sfc-gh-kwagner @sfc-gh-jdu @sfc-gh-yixie