-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1637948: Add support for TimedeltaIndex methods floor, ceil and round #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1637948-tdi-methods
branch
from
September 5, 2024 23:10
a266225
to
71c6a2d
Compare
sfc-gh-azhan
reviewed
Sep 6, 2024
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
sfc-gh-azhan
reviewed
Sep 6, 2024
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
sfc-gh-azhan
reviewed
Sep 6, 2024
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1637948-tdi-methods
branch
from
September 6, 2024 03:15
71c6a2d
to
9566097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, left just two minor comments. Please address the other comments as well.
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
sfc-gh-azhan
reviewed
Sep 6, 2024
sfc-gh-azhan
reviewed
Sep 6, 2024
sfc-gh-azhan
reviewed
Sep 6, 2024
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1637948-tdi-methods
branch
from
September 6, 2024 19:07
86ceae3
to
6e9e0cd
Compare
sfc-gh-azhan
approved these changes
Sep 6, 2024
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
sfc-gh-helmeleegy
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a few nits.
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1637948-tdi-methods
branch
from
September 6, 2024 20:09
6e9e0cd
to
c2a175b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SNOW-1637948
Add support for TimedeltaIndex methods floor, ceil and round