Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1637948: Add support for TimedeltaIndex methods floor, ceil and round #2243

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

sfc-gh-nkumar
Copy link
Contributor

Fixes SNOW-1637948

Add support for TimedeltaIndex methods floor, ceil and round

@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1637948-tdi-methods branch from 71c6a2d to 9566097 Compare September 6, 2024 03:15
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left just two minor comments. Please address the other comments as well.

@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1637948-tdi-methods branch from 86ceae3 to 6e9e0cd Compare September 6, 2024 19:07
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a few nits.

@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1637948-tdi-methods branch from 6e9e0cd to c2a175b Compare September 6, 2024 20:09
@sfc-gh-nkumar sfc-gh-nkumar merged commit 3df2d99 into main Sep 6, 2024
35 of 37 checks passed
@sfc-gh-nkumar sfc-gh-nkumar deleted the nkumar-SNOW-1637948-tdi-methods branch September 6, 2024 21:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants