Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1632086: update gh action name to verify signature #2121

Merged
merged 1 commit into from
Aug 19, 2024
Merged

SNOW-1632086: update gh action name to verify signature #2121

merged 1 commit into from
Aug 19, 2024

Conversation

sfc-gh-anavalos
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1632086

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.
    Signing process is failing to validate the signature due it uses the gh action name for it. The script had a different file name and the fix is to use the correct one.

@sfc-gh-anavalos sfc-gh-anavalos requested review from a team as code owners August 19, 2024 16:33
@sfc-gh-anavalos sfc-gh-anavalos added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 19, 2024
sfc-gh-kdama
sfc-gh-kdama approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-kdama sfc-gh-kdama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfc-gh-anavalos sfc-gh-anavalos merged commit 37d7cfd into main Aug 19, 2024
34 of 35 checks passed
@sfc-gh-anavalos sfc-gh-anavalos deleted the gh-sfc-anavalos-fix-sign-gh-action branch August 19, 2024 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-kdama sfc-gh-kdama sfc-gh-kdama approved these changes

@sfc-gh-mvashishtha sfc-gh-mvashishtha Awaiting requested review from sfc-gh-mvashishtha sfc-gh-mvashishtha is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Awaiting requested review from sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-anavalos @sfc-gh-kdama @sfc-gh-aalam