Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1552816 : Fix Session.lineage.trace API output for feature views #1990

Merged
merged 2 commits into from
Jul 30, 2024
Merged

SNOW-1552816 : Fix Session.lineage.trace API output for feature views #1990

merged 2 commits into from
Jul 30, 2024

Conversation

sfc-gh-rsureshbabu
Copy link
Collaborator

@sfc-gh-rsureshbabu sfc-gh-rsureshbabu commented Jul 28, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1552816
    Quoted Feature view names were not correctly split. This PR fixes that

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-rsureshbabu sfc-gh-rsureshbabu marked this pull request as ready for review July 28, 2024 03:05
@sfc-gh-rsureshbabu sfc-gh-rsureshbabu requested a review from a team as a code owner July 28, 2024 03:05
sfc-gh-wezhou
sfc-gh-wezhou approved these changes Jul 29, 2024
View reviewed changes
src/snowflake/snowpark/lineage.py
@@ -424,10 +424,13 @@ def _get_name_and_version(self, graph_entity: Dict[str, Any]):
if user_domain in self._versioned_object_domains:
if user_domain == _UserDomain.FEATURE_VIEW:
if "$" in name:
parts = name.split("$")
had_quotes = name.startswith('"') and name.endswith('"')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: has_quotes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I didnt see this. I have another PR open, I will fix this in that one

@sfc-gh-rsureshbabu sfc-gh-rsureshbabu changed the title SNOW-1552816 : Fix Dataframe.lineage.trace API output for feature views SNOW-1552816 : Fix Session.lineage.trace API output for feature views Jul 30, 2024
@sfc-gh-rsureshbabu sfc-gh-rsureshbabu merged commit 5130ae3 into main Jul 30, 2024
34 checks passed
@sfc-gh-rsureshbabu sfc-gh-rsureshbabu deleted the rsureshbabu-SNOW-1552816-fixFVsplitting branch July 30, 2024 01:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-wezhou sfc-gh-wezhou sfc-gh-wezhou approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-rsureshbabu @sfc-gh-wezhou @sfc-gh-jrose