Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1476363: Add groupby().size() pandas API #1763

Merged
merged 12 commits into from
Jun 14, 2024
Merged

SNOW-1476363: Add groupby().size() pandas API #1763

merged 12 commits into from
Jun 14, 2024

Conversation

sfc-gh-dpetersohn
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1476363

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Add the pandas API groupby().size() to Snowpark pandas.

@sfc-gh-dpetersohn sfc-gh-dpetersohn requested a review from a team as a code owner June 12, 2024 18:35
@sfc-gh-dpetersohn
SNOW-1476363: Add groupby().size() pandas API
bb52cad 
Signed-off-by: Devin Petersohn <[email protected]>
@sfc-gh-dpetersohn
Update docs
f16632f 
Signed-off-by: Devin Petersohn <[email protected]>
@sfc-gh-dpetersohn
Lint
07aa1a2 
Signed-off-by: Devin Petersohn <[email protected]>
@sfc-gh-dpetersohn
Changelog
985e211 
Signed-off-by: Devin Petersohn <[email protected]>
sfc-gh-azhan
sfc-gh-azhan reviewed Jun 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-dpetersohn
Address comments
6784f44 
Signed-off-by: Devin Petersohn <[email protected]>
@sfc-gh-dpetersohn
Address some more
2c5dd21 
Signed-off-by: Devin Petersohn <[email protected]>
sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/integ/modin/groupby/test_groupby_size.py Show resolved Hide resolved
@sfc-gh-dpetersohn
Address
7309f68 
Signed-off-by: Devin Petersohn <[email protected]>
@sfc-gh-dpetersohn
Remove axis 1
f4bc486 
Signed-off-by: Devin Petersohn <[email protected]>
@sfc-gh-dpetersohn
Add random
36e8b74 
Signed-off-by: Devin Petersohn <[email protected]>
@sfc-gh-dpetersohn
Merge branch 'main' into devin/1476363
6ca81c2
@sfc-gh-dpetersohn sfc-gh-dpetersohn enabled auto-merge (squash) June 14, 2024 15:42
@sfc-gh-dpetersohn
Doc fix
8dc0568 
Signed-off-by: Devin Petersohn <[email protected]>
@sfc-gh-dpetersohn sfc-gh-dpetersohn merged commit 04370fe into main Jun 14, 2024
35 checks passed
@sfc-gh-dpetersohn sfc-gh-dpetersohn deleted the devin/1476363 branch June 14, 2024 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan left review comments

@sfc-gh-mvashishtha sfc-gh-mvashishtha sfc-gh-mvashishtha approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-yzou sfc-gh-yzou sfc-gh-yzou approved these changes

@sfc-gh-evandenberg sfc-gh-evandenberg Awaiting requested review from sfc-gh-evandenberg sfc-gh-evandenberg is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-rdurrani sfc-gh-rdurrani Awaiting requested review from sfc-gh-rdurrani sfc-gh-rdurrani is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-dpetersohn @sfc-gh-azhan @sfc-gh-yzou @sfc-gh-nkrishna @sfc-gh-mvashishtha