Skip to content

Commit

Permalink
additional test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-jrose committed Dec 12, 2024
1 parent 7cc0204 commit 0f2d9d2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/snowflake/snowpark/_internal/analyzer/analyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ def do_resolve_with_resolved_children(
logical_plan,
logical_plan.left_cols,
logical_plan.right_cols,
self.session.conf.get("use_constant_subquery_alias", False),
bool(self.session.conf.get("use_constant_subquery_alias", False)),
)

if isinstance(logical_plan, TableFunctionRelation):
Expand Down Expand Up @@ -935,7 +935,7 @@ def do_resolve_with_resolved_children(
join_condition,
match_condition,
logical_plan,
self.session.conf.get("use_constant_subquery_alias", False),
bool(self.session.conf.get("use_constant_subquery_alias", False)),
)

if isinstance(logical_plan, Sort):
Expand Down
2 changes: 1 addition & 1 deletion src/snowflake/snowpark/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ def __setattr__(self, name, value):
super().__setattr__(name, value)

@property
def large_query_breakdown_complexity_bounds(self):
def large_query_breakdown_complexity_bounds(self) -> Tuple[int, int]:
return (
self._conf.get("_large_query_breakdown_complexity_lower_bound"),
self._conf.get("_large_query_breakdown_complexity_upper_bound"),
Expand Down
2 changes: 1 addition & 1 deletion tests/perf/perf_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def compute_plan_height_time(dataframe):

session = Session.builder.configs(CONNECTION_PARAMETERS).create()
session.sql_simplifier_enabled = args.simplify
session._cte_optimization_enabled = args.cte
session.cte_optimization_enabled = args.cte
print("Snowpark Python API Performance Test")
print("Parameters: ", args)
try:
Expand Down

0 comments on commit 0f2d9d2

Please sign in to comment.