Internalize opentelemetry-exporter-otlp-proto-common adapter code #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opentelemetry-exporter-otlp-proto-common
encoder / adapter logic that converts SDK objects into serializable pb2 protobuf generated objectsvendor_otlp_proto_common.sh
that clones the repo for a desired version, and replaces the necessary imports in the file. The copied files retain the copyright notice and append a notice that the file has been modifiedopentelemetry-exporter-otlp-proto-common
, andprotobuf
by extensiongit diff --no-index ~/opentelemetry-python/exporter/opentelemetry-exporter-otlp-proto-common/src/opentelemetry/exporter/otlp/proto/common ~/snowflake-telemetry-python/src/snowflake/telemetry/_internal/opentelemetry/exporter/otlp/proto/common
Upcoming PRs
Benchmarks
opentelemetry-exporter-otlp-proto-common
encoder using protobuf vs internalizedopentelemetry-exporter-otlp-proto-common
encoder using pure python marshaler objects.Testing
opentlemetry-proto
to ensure there is no regression