SNOW-1806157 Fix field id mismatch during schema evolution for structured data type #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-alhuang
requested review from
sfc-gh-tzhang and
a team
as code owners
sfc-gh-hmadan
approved these changes
Nov 14, 2024
| () -> | ||
| new SFException( | ||
| ErrorCode.INTERNAL_ERROR, | ||
| String.format("Column not found. ordinal=%d.", ordinal))) |
There was a problem hiding this comment.
also log more info like columnDotPath / columnDescriptor / fieldId ?
There was a problem hiding this comment.
github.dev didn't post this comment just realized!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the error when the column ordinal of structured data is out of order. The logic used to assume that the root columns are the first k smallest of whole schema, which is incorrect after schema evolution. Add a map for column ordinal to column to fix this.