add more tests and error log

snowflakedb · Jan 15, 2025 · ab63dfa · ab63dfa
1 parent 8eed776
commit ab63dfa
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/src/main/java/net/snowflake/ingest/streaming/internal/DataValidationUtil.java b/src/main/java/net/snowflake/ingest/streaming/internal/DataValidationUtil.java
@@ -181,7 +181,12 @@ private static String validateAndParseSemiStructured(
           throw valueFormatNotAllowedException(
               columnName, snowflakeType, "Not a valid JSON: duplicate field", insertRowIndex);
         }
-        throw new SFException(e, ErrorCode.IO_ERROR, "Cannot create JSON Parser or JSON generator");
+        throw new SFException(
+            e,
+            ErrorCode.IO_ERROR,
+            String.format(
+                "Cannot create JSON Parser or JSON generator for column %s of type %s, rowIndex:%d",
+                columnName, snowflakeType, insertRowIndex));
       }
       // We return the minified string from the result writer
       return resultWriter.toString();

diff --git a/src/test/java/net/snowflake/ingest/streaming/internal/DataValidationUtilTest.java b/src/test/java/net/snowflake/ingest/streaming/internal/DataValidationUtilTest.java
@@ -862,10 +862,9 @@ public void testValidateDuplicateKeys() {
     expectError(
         ErrorCode.INVALID_VALUE_ROW,
         () -> validateAndParseObjectNew("COL", "{\"key\":1, \"key\":2}", 0));
-
     expectError(
         ErrorCode.INVALID_VALUE_ROW,
-        () -> validateAndParseObjectNew("COL", "{\"key\":1, \"key\":2}".getBytes(), 0));
+        () -> validateAndParseVariantNew("COL", "{\"key\":1, \"key\":2}", 0));
 
     // nested JSON object with duplicate keys can not be ingested
     expectError(
@@ -875,8 +874,15 @@ public void testValidateDuplicateKeys() {
     expectError(
         ErrorCode.INVALID_VALUE_ROW,
         () ->
-            validateAndParseObjectNew(
-                "COL", "{\"key\":1, \"nested\":{\"key\":2, \"key\":3}}".getBytes(), 0));
+            validateAndParseVariantNew("COL", "{\"key\":1, \"nested\":{\"key\":2, \"key\":3}}", 0));
+
+    // array of objects with duplicate keys can not be ingested
+    expectError(
+        ErrorCode.INVALID_VALUE_ROW,
+        () -> validateAndParseArrayNew("COL", "[{\"key\":1, \"key\":2}]", 0));
+    expectError(
+        ErrorCode.INVALID_VALUE_ROW,
+        () -> validateAndParseVariantNew("COL", "[{\"key\":1, \"key\":2}]", 0));
   }
 
   @Test