freeze asn1crypto version as 1.0.0 is incompatible with 1.9.0 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't see a 1.9 version branch so I opened PR against master. Obviously not the right merge target but wanted to get the convo started on the issue. |
|
We'll patch this change in 2.0.1. Thanks for PR. |
|
@smtakeda any chance we can do a 1.9.1 release as well? We have not moved to 2.0.0 yet. |
|
No, we don't have a policy to patch older version as of today. |
|
@erikselin We released 1.9.1 as more customers demanded. Please try. |
erikselin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best fix but 1.9.0 (and likely many versions below) are broken following the asn2crypto 1.0.0 release a few hours ago. Opening this PR here since I'm sure it will become a problem for many users who are not on 2.0.0 yet.